Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(color_thresholds): explain resulting colors #1058

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

ildar170975
Copy link
Collaborator

Copy link
Collaborator

@akloeckner akloeckner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you base this PR towards the dev branch, please? (Maybe it'll be time to merge dev into master, afterwards.)

I also added a comment to the new text.

README.md Outdated Show resolved Hide resolved
@ildar170975 ildar170975 changed the base branch from master to dev January 19, 2024 00:43
Copy link
Collaborator

@akloeckner akloeckner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the suggestion-feature to give an example for the list, I was refering to. I couldn't see this as rendered markdown in the comment, but I think, it should be the right syntax.

We should also fix the PR title to something semantic, e.g. docs(color_thresholds): explain resulting colors. That way, we will have a semantic commit title, when we "squash and merge". And that will result in the release being bumped properly.

README.md Outdated Show resolved Hide resolved
Co-authored-by: akloeckner <[email protected]>
@ildar170975 ildar170975 changed the title Update README.md: color_thresholds docs(color_thresholds): explain resulting colors Jan 20, 2024
@akloeckner
Copy link
Collaborator

Looks great! I'll merge it. Thanks!

@akloeckner akloeckner merged commit 0d26f7c into kalkih:dev Jan 20, 2024
4 of 5 checks passed
Copy link

🎉 This PR is included in version 0.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants